From 9add60735efa9d58bcfadd59f2130ed793dff1c3 Mon Sep 17 00:00:00 2001
From: Ari Yeger <yegera1@newpaltz.edu>
Date: Wed, 23 Jul 2025 16:24:47 -0400
Subject: [PATCH] refactor: streamline SVG handling and improve error messages
 in user and email controllers

---
 .../src/components/baseComponents/BaseSVG.vue | 60 ++++++++++++-------
 client/src/directives/vRecolorText.ts         |  8 +--
 client/src/models/session.ts                  |  5 +-
 client/src/views/LoginPage.vue                | 19 +++---
 server/app.js                                 | 18 +-----
 server/controllers/emailController.js         |  6 +-
 server/controllers/userController.js          | 28 ++++-----
 7 files changed, 72 insertions(+), 72 deletions(-)

diff --git a/client/src/components/baseComponents/BaseSVG.vue b/client/src/components/baseComponents/BaseSVG.vue
index 27dda4f..9907591 100644
--- a/client/src/components/baseComponents/BaseSVG.vue
+++ b/client/src/components/baseComponents/BaseSVG.vue
@@ -1,35 +1,50 @@
 <script setup lang="ts">
-import { ref, watchEffect, computed} from 'vue';
+import {ref, computed} from 'vue';
 import vRecolorSvg from '@/directives/vRecolorSvg.ts';
 
 const props = defineProps<{
-    svgUrl: string;
+    svg: string;
     width?: number;
     height?: number;
     viewBox?: string;
 }>();
 
-const paths = ref<Array<{ clip: string; d: string; fill: "nonzero" | "evenodd" | "inherit" | undefined}>>([]);
+const paths = ref<Array<{
+    'clip-rule': string | undefined;
+    d: string | undefined;
+    'fill-rule': "nonzero" | "evenodd" | "inherit" | undefined
+}>>([]);
+
+const svgPaths = props.svg
+    .replace(/%20/g, " ")
+    .replace(/%3c/g, "<")
+    .replace(/%3e/g, ">")
+    .split('path')
+    .map(chunk => chunk.trim())
+    .filter((chunk) => !chunk.startsWith('data:image'))
+    .map((path) => path
+        .split('/>')[0]
+        .replace(/fill=.* /g, "")
+        .replace(/["']/g, ""));
+
+try {
+    for (const path of svgPaths) {
+        const match = {
+            'clip-rule': /clip-rule=(\w+)/.exec(path),
+            'd': /d=(.*Z)/.exec(path),
+            'fill-rule': /fill-rule=(\w+)/.exec(path),
+        }
+        paths.value.push({
+            'clip-rule': match['clip-rule'] ? match['clip-rule'][1].toString() : undefined,
+            'd': match['d'] ? match['d'][1].toString() : undefined,
+            'fill-rule': match['fill-rule'] ? match['fill-rule'][1].toString() as "nonzero" | "evenodd" | "inherit" : undefined,
+        });
 
-watchEffect(async () => {
-    if (!props.svgUrl) {
-        paths.value = [];
-        return;
     }
-    try {
-        const response = await fetch(props.svgUrl);
-        const svgText = await response.text();
-        const parser = new DOMParser();
-        const doc = parser.parseFromString(svgText, 'image/svg+xml');
-        paths.value = Array.from(doc.querySelectorAll('path')).map(path => ({
-            clip: path.getAttribute('clip-rule') || 'nonzero',
-            d: path.getAttribute('d') || '',
-            fill: (path.getAttribute('fill-rule') as "nonzero" | "evenodd" | "inherit" | undefined) || "inherit",
-        }));
-    } catch {
-        paths.value = [];
-    }
-});
+} catch (error) {
+    console.error('Error processing SVG paths:', error);
+    paths.value = [];
+}
 
 const svgStyle = computed(() => ({
     width: props.width ? `${props.width}px` : '100%',
@@ -40,7 +55,8 @@ const svgStyle = computed(() => ({
 <template>
     <svg xmlns="http://www.w3.org/2000/svg" :viewBox="svgStyle.viewBox" :width="svgStyle.width"
          :height="svgStyle.height">
-        <path v-for="(path, index) in paths" :key="index" :clip-rule="path.clip" :d="path.d" :fill-rule="path.fill" v-recolor-svg/>
+        <path v-for="(path, index) in paths" :key="index" :clip-rule="path['clip-rule']" :d="path['d']"
+              :fill-rule="path['fill-rule']" v-recolor-svg/>
     </svg>
 </template>
 
diff --git a/client/src/directives/vRecolorText.ts b/client/src/directives/vRecolorText.ts
index 6ceadf2..0d11887 100644
--- a/client/src/directives/vRecolorText.ts
+++ b/client/src/directives/vRecolorText.ts
@@ -76,7 +76,7 @@ export function useReadableTextColor(bgColor: string): string {
     let whiteRatio = (whiteLighter + 0.05) / (whiteDarker + 0.05);
     // Return black or white based on luminance
     if (blackRatio >= 4.5 || whiteRatio >= 4.5) {
-        console.debug("bgL:", bgLuminance, "bL:", blackLuminance, "wL:", whiteLuminance, "bR:", blackRatio, "wR:", whiteRatio);
+        //console.debug("bgL:", bgLuminance, "bL:", blackLuminance, "wL:", whiteLuminance, "bR:", blackRatio, "wR:", whiteRatio);
         return blackRatio > whiteRatio ? '#181818' : '#E7E7E7';
     }
     // If contrast is not enough, use deep colors
@@ -87,7 +87,7 @@ export function useReadableTextColor(bgColor: string): string {
     blackRatio = (blackLighter + 0.05) / (blackDarker + 0.05);
     whiteRatio = (whiteLighter + 0.05) / (whiteDarker + 0.05);
     if (blackRatio >= 4.5 || whiteRatio >= 4.5) {
-        console.debug("bgL:", bgLuminance, "bL:", blackLuminanceDeep, "wL:", whiteLuminanceDeep, "bR:", blackRatio, "wR:", whiteRatio);
+        //console.debug("bgL:", bgLuminance, "bL:", blackLuminanceDeep, "wL:", whiteLuminanceDeep, "bR:", blackRatio, "wR:", whiteRatio);
         return blackRatio > whiteRatio ? '#0B0B0B' : '#F4F4F4';
     }
     // If still not enough, use absolute colors
@@ -98,10 +98,10 @@ export function useReadableTextColor(bgColor: string): string {
     blackRatio = (blackLighter + 0.05) / (blackDarker + 0.05);
     whiteRatio = (whiteLighter + 0.05) / (whiteDarker + 0.05);
     if (blackRatio >= 4.5 || whiteRatio >= 4.5) {
-        console.debug("bgL:", bgLuminance, "bL:", blackLuminanceAbsolute, "wL:", whiteLuminanceAbsolute, "bR:", blackRatio, "wR:", whiteRatio);
+        //console.debug("bgL:", bgLuminance, "bL:", blackLuminanceAbsolute, "wL:", whiteLuminanceAbsolute, "bR:", blackRatio, "wR:", whiteRatio);
         return blackRatio > whiteRatio ? '#000000' : '#FFFFFF';
     }
-    console.warn(`Not enough contrast for background color: ${bgColor}. Using fallback colors.`);
+    //console.warn(`Not enough contrast for background color: ${bgColor}. Using fallback colors.`);
     return bgLuminance > 0.5 ? blackTextColor : whiteTextColor; // Fallback to default colors
 }
 
diff --git a/client/src/models/session.ts b/client/src/models/session.ts
index 47c9d54..5120fd9 100644
--- a/client/src/models/session.ts
+++ b/client/src/models/session.ts
@@ -27,6 +27,7 @@ export function useLogin() {
         async login(username: string, password: string): Promise<SecureUser> {
             return await api<SecureUser>("/users/login", {username, password}, "POST")
                 .then((response: DataEnvelope<SecureUser> ) => {
+                    if (!response.data) throw new Error("Invalid login credentials. Please try again.");
                     session.user = response.data;
                     if (!session.user) throw new Error("Invalid login credentials. Please try again.");
                     session.token = response.data.token || null;
@@ -37,7 +38,9 @@ export function useLogin() {
                     localStorage.setItem("token", session.token ?? "");
                     return session.user;
                 })
-                .catch((err)=>{throw err}) as SecureUser;
+                .catch((envelope: DataEnvelope<any>)=>{
+                    toast.error(envelope.message || envelope.error?.message || "An error occurred while trying to log in. Please try again later.")
+                }) as SecureUser;
         },
         async logout(): Promise<void> {
             session.user = null;
diff --git a/client/src/views/LoginPage.vue b/client/src/views/LoginPage.vue
index ffd29b8..2e6174b 100644
--- a/client/src/views/LoginPage.vue
+++ b/client/src/views/LoginPage.vue
@@ -2,16 +2,17 @@
 import {ref} from 'vue';
 import {useLogin} from "@models/session.ts";
 import {isMobile} from "@models/globals.ts";
-import vRecolorSvg from '@/directives/vRecolorSvg.ts';
+import eye from '@/assets/svg/eye.svg';
+import eyeSlash from '@/assets/svg/eye-slash.svg';
 import BaseButton from "@components/baseComponents/BaseButton.vue";
 import BaseSVG from "@components/baseComponents/BaseSVG.vue";
 import BaseInput from "@components/baseComponents/BaseInput.vue";
 
+
 const username = ref('');
 const password = ref('');
 const {login} = useLogin();
 const showPassword = ref(false);
-
 </script>
 
 <template>
@@ -29,17 +30,15 @@ const showPassword = ref(false);
                         <label class="form-label" for="password">Password</label>
                         <div class="input-group">
                             <BaseInput class="form-control" id="password" v-model="password"
-                                   :type="showPassword ? 'text' : 'password'"
-                                   autocomplete="current-password" required style="border-right:0;"/>
+                                       :type="showPassword ? 'text' : 'password'"
+                                       autocomplete="current-password" required style="border-right:0;"/>
                             <button type="button" class="input-group-text border-start-0"
                                     style="cursor:pointer;"
                                     @click="showPassword = !showPassword">
-                                    <BaseSVG svg-url="/src/assets/svg/eye.svg" :width="20" :height="20"
-                                             view-box="0 0 28 28"
-                                             v-recolor-svg v-if="!showPassword"/>
-                                    <BaseSVG svg-url="/src/assets/svg/eye-slash.svg" :width="20" :height="20"
-                                             view-box="0 0 28 28"
-                                             v-recolor-svg v-else/>
+                                <BaseSVG :svg="eye" :width="20" :height="20"
+                                         view-box="0 0 28 28" v-if="!showPassword"/>
+                                <BaseSVG :svg="eyeSlash" :width="20" :height="20"
+                                         view-box="0 0 28 28" v-else/>
                             </button>
                         </div>
                     </div>
diff --git a/server/app.js b/server/app.js
index 5e8601d..726b8e8 100644
--- a/server/app.js
+++ b/server/app.js
@@ -1,32 +1,20 @@
 // server/app.js
+console.log("Starting Server...");
 import express from 'express';
 import cors from 'cors';
 // import multer from 'multer';
 // import path from 'path';
 import db from './models/db.js';
 import dotenv from 'dotenv';
-import emailController from "./controllers/emailController.js";
 
 dotenv.config();
 
-/**@typedef {import("../client/src/DBRecord.ts").DBRecord} DBRecord */
-
-console.log("Starting Server...");
 // test db connection
 try {
     await db.query("SELECT 1")
     console.log("DB connection successful")
     await db.get('users', {id: 1});
     console.log("Users table exists");
-
-    await emailController.withTimeout(emailController.transporter.verify(), 15000)
-        .then(() => {
-            console.log("Transporter is ready to send emails");
-        })
-        .catch((error) => {
-            console.error("Error verifying transporter:", error);
-            process.exit(1);
-        });
 } catch (err) {
     console.error(err);
     process.exit(1);
@@ -52,11 +40,11 @@ const upload = multer({storage});*/
 
 // user routes
 import userRouter from './controllers/userController.js';
-
 app.use('/api/users', userRouter);
 
 // email routes
-app.use('/api/email', emailController.router);
+import emailRouter from "./controllers/emailController.js";
+app.use('/api/email', emailRouter);
 
 // other routes
 
diff --git a/server/controllers/emailController.js b/server/controllers/emailController.js
index 8a07109..9fe10f7 100644
--- a/server/controllers/emailController.js
+++ b/server/controllers/emailController.js
@@ -144,9 +144,5 @@ async function withTimeout(promise, ms) {
 }
 
 
-export default {
-    withTimeout,
-    transporter,
-    router
-};
+export default router;
 
diff --git a/server/controllers/userController.js b/server/controllers/userController.js
index 27e9a55..f6a3e1f 100644
--- a/server/controllers/userController.js
+++ b/server/controllers/userController.js
@@ -41,12 +41,12 @@ router.get("/",
      */
     async (req, res, next) => {
         if (!req.body || !req.body.username || !req.body.password) {
-            return res.status(400).json({data: null, error: 'Username and password are required'});
+            return res.status(400).json({data: null, message: 'Username and password are required'});
         }
         await users.addNewUser(req.body.username, req.body.password)
             .then((user) => {
                 if (!user) {
-                    return res.status(500).json({data: null, error: 'User not found after insertion'});
+                    return res.status(500).json({data: null, message: 'User not found after insertion'});
                 }
                 res.status(200).json({data: user, message: 'User added successfully'});
             })
@@ -64,21 +64,21 @@ router.get("/:identifier",
      */
     async (req, res, next) => {
         const userIdentifier = req.params.identifier;
-        if (!userIdentifier) return res.status(400).json({data: null, error: 'User identifier is required'});
+        if (!userIdentifier) return res.status(400).json({data: null, message: 'User identifier is required'});
         await users.getUser(userIdentifier)
             .then(user => {
-                if (!user) return res.status(404).json({data: null, error: 'User not found'});
+                if (!user) return res.status(404).json({data: null, message: 'User not found'});
                 res.status(200).json({data: user});
             })
             .catch((err) => {
                 if (err instanceof Error) {
                     if (err.message === 'User not found') {
-                        return res.status(404).json({data: null, error: 'User not found'});
+                        return res.status(404).json({data: null, error: err});
                     }
                     if (err.message === 'Multiple users found with the same identifier, something has gone wrong') {
                         res.status(500).json({
                             data: null,
-                            error: 'Multiple users found with the same identifier, something has gone wrong'
+                            error: err
                         });
                     } else next(err);
                 } else {
@@ -100,16 +100,16 @@ router.post("/login",
         const {username, password} = req.body;
         if (!username || !password) return res.status(400).json({
             data: null,
-            error: 'Username and password are required'
+            message: 'Username and password are required'
         });
         await users.login(username, password).then(data => {
-            if (!data) return res.status(401).json({data: null, error: 'Invalid username or password'});
+            if (!data) return res.status(401).json({data: null, message: 'Invalid username or password'});
             res.status(200).json({data: data, message: 'Login successful'});
         })
             .catch((err) => {
                 if (err instanceof Error) {
                     if (err.message === 'Invalid username or password') {
-                        res.status(401).json({data: null, error: 'Invalid username or password'});
+                        res.status(401).json({data: null, error: err});
                     } else next(err);
                 } else {
                     next(new Error('An unhandled error occurred while login'));
@@ -127,12 +127,10 @@ router.patch("/:identifier", authHandler.authenticateUser,
      */
     async (req, res, next) => {
         const userIdentifier = req.params.id;
-        if (!userIdentifier) {
-            return res.status(400).json({data: null, error: 'User Identifier is required'});
-        }
+        if (!userIdentifier) return res.status(400).json({data: null, message: 'User Identifier is required'});
         await users.updateUser(req.body)
             .then(user => {
-                if (!user) res.status(404).json({data: null, error: 'User not found'});
+                if (!user) res.status(404).json({data: null, message: 'User not found'});
                 else res.status(200).json({data: user, message: 'User updated successfully'});
             })
             .catch((err) => next(err))
@@ -150,10 +148,10 @@ router.delete("/:identifier", authHandler.authenticateUser,
      */
     async (req, res, next) => {
         const userIdentifier = req.params.identifier;
-        if (!userIdentifier) return res.status(400).json({data: null, error: 'User identifier is required'});
+        if (!userIdentifier) return res.status(400).json({data: null, message: 'User identifier is required'});
         await users.deleteUser(userIdentifier)
             .then(user => {
-                if (!user) return res.status(404).json({data: null, error: 'User not found'});
+                if (!user) return res.status(404).json({data: null, message: 'User not found'});
                 res.status(200).json({data: user, message: 'User deleted successfully'});
             })
             .catch((err) => next(err));